2112023b6e
* Phase 4: async pipeline (Celery+Redis), Postgres job state, local-fs blob storage, API-key auth, Prometheus metrics Co-Authored-By: adrian kuman firmansah <adriancuman@gmail.com> * Phase 4: fix sync-mode rollback orphaning blobs + use is_relative_to for path-escape check Devin Review on PR #3 found two real bugs: 1. Sync path mark_failed was rolled back by the request-scoped session. When the pipeline raised an exception in ?sync=true mode, _run_inline modified the FastAPI session and re-raised; get_session caught the exception, called session.rollback(), and wiped both the create() and the mark_failed() writes. The blob was already on disk, so it was permanently orphaned with no DB record. Fix: commit the pending row immediately after create(), and run all subsequent state transitions in independent session_scope blocks (matching the worker task pattern). 2. _resolve used str.startswith for path-escape detection, which lets a sibling directory whose name begins with the storage root pass (e.g. /app/blobs_evil vs /app/blobs). Switched to Path.is_relative_to. Added regression tests for both. Co-Authored-By: adrian kuman firmansah <adriancuman@gmail.com> * Phase 4: honor queue_enabled setting + resolve base_dir for path comparisons Two more bugs found by Devin Review: 3. queue_enabled was declared in config and documented in .env.example but never read by the route. A fresh dev install with QUEUE_ENABLED=false (the default) would still enqueue, then fail with a Redis connection error. Fixed by making the ?sync= query param default to None and resolving to (not queue_enabled) inside the route. Tests now set QUEUE_ENABLED=true so the async flow stays exercised, and a new test verifies the inline fallback when the queue is disabled. 4. LocalFsBlobStorage stored base_dir as-is. _resolve resolved its candidate paths, so the empty-dir cleanup loop in delete() compared a resolved candidate against an unresolved base_dir and broke on the first iteration (no cleanup ever happened). Fixed by resolving base_dir once in __init__ so every path comparison is apples-to-apples. Co-Authored-By: adrian kuman firmansah <adriancuman@gmail.com> * Phase 4: derive ocr_jobs_total from DB so worker writes are visible at /metrics Devin Review correctly noted the Counter-based JOBS_TOTAL would never increment in production because the worker runs in a separate process from the API and the registry is process-local. Replaced JOBS_TOTAL with a custom Collector that issues SELECT status, COUNT(*) FROM jobs GROUP BY status on every /metrics scrape. Result: the metric stays accurate regardless of which process wrote the row. Also corrected the metrics.py docstring (the old comment claimed the counter was 'incremented by the worker', which was the bug). Removed the JOBS_TOTAL.inc() calls from the sync route — the DB collector covers both paths now. JOB_PROCESSING_SECONDS stays as an API-process histogram with an updated docstring noting its scope; cross-process latency belongs to derived dashboards over jobs.created_at/updated_at. Added regression test test_metrics_jobs_total_reflects_worker_writes. Co-Authored-By: adrian kuman firmansah <adriancuman@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: adrian kuman firmansah <adriancuman@gmail.com>
77 lines
2.5 KiB
Python
77 lines
2.5 KiB
Python
"""SQLAlchemy repository tests against an in-memory sqlite db."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
|
|
from ocr_sprint.db.base import Base, get_engine, session_scope
|
|
from ocr_sprint.db.repositories import JobNotFoundError, JobRepository
|
|
from ocr_sprint.schemas.document import DocumentStatus, SourceKind
|
|
|
|
|
|
@pytest.fixture
|
|
def db_ready() -> None:
|
|
Base.metadata.create_all(bind=get_engine())
|
|
|
|
|
|
def test_create_then_fetch(db_ready: None) -> None:
|
|
jid = uuid4()
|
|
with session_scope() as session:
|
|
JobRepository(session).create(
|
|
job_id=jid,
|
|
filename="x.pdf",
|
|
source_kind=SourceKind.PDF,
|
|
blob_key="2026/01/01/x.pdf",
|
|
)
|
|
with session_scope() as session:
|
|
row = JobRepository(session).get_or_raise(jid)
|
|
assert row.status == DocumentStatus.PENDING.value
|
|
assert row.source_kind == SourceKind.PDF.value
|
|
assert row.blob_key == "2026/01/01/x.pdf"
|
|
|
|
|
|
def test_lifecycle_transitions(db_ready: None) -> None:
|
|
jid = uuid4()
|
|
with session_scope() as session:
|
|
JobRepository(session).create(
|
|
job_id=jid,
|
|
filename="x.pdf",
|
|
source_kind=SourceKind.PDF,
|
|
blob_key="k",
|
|
)
|
|
with session_scope() as session:
|
|
JobRepository(session).mark_processing(jid)
|
|
with session_scope() as session:
|
|
repo = JobRepository(session)
|
|
repo.mark_completed(
|
|
jid,
|
|
status=DocumentStatus.NEEDS_REVIEW,
|
|
confidence=0.88,
|
|
result={"header": {"nomor_sprint": "Sprin/1/2025"}},
|
|
review_flags=["low_ocr_confidence"],
|
|
)
|
|
row = repo.get_or_raise(jid)
|
|
assert row.status == DocumentStatus.NEEDS_REVIEW.value
|
|
assert row.confidence == 0.88
|
|
assert row.result == {"header": {"nomor_sprint": "Sprin/1/2025"}}
|
|
assert row.review_flags == ["low_ocr_confidence"]
|
|
|
|
|
|
def test_mark_failed_truncates_long_error(db_ready: None) -> None:
|
|
jid = uuid4()
|
|
with session_scope() as session:
|
|
JobRepository(session).create(
|
|
job_id=jid, filename="x", source_kind=SourceKind.UNKNOWN, blob_key="k"
|
|
)
|
|
with session_scope() as session:
|
|
JobRepository(session).mark_failed(jid, error="x" * 5000)
|
|
row = JobRepository(session).get_or_raise(jid)
|
|
assert len(row.error or "") == 2048
|
|
|
|
|
|
def test_unknown_job_raises(db_ready: None) -> None:
|
|
with session_scope() as session, pytest.raises(JobNotFoundError):
|
|
JobRepository(session).get_or_raise(uuid4())
|